| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20210621124716.GD1408@agape.jhs>
Date: Mon, 21 Jun 2021 14:47:17 +0200
From: Fabio Aiuto <fabioaiuto83@...il.com>
To: Hans de Goede <hdegoede@...hat.com>
Cc: gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/18] staging: rtl8723bs: remove 5Ghz code
Hello Hans,
On Mon, Jun 21, 2021 at 11:49:47AM +0200, Hans de Goede wrote:
> Hi Fabio,
>
> On 6/19/21 12:47 PM, Fabio Aiuto wrote:
> > This patch series removes all occurences of 5Ghz code over the
> > driver as required from driver's TODO list:
> >
> > - find and remove remaining code valid only for 5 GHz.
> > most of the obvious one have been removed, but things
> > like channel > 14 still exist.
> >
> > rtl8723bs work on 2.4Ghz band and supports 802.11bgn standards.
> > So all code related to 802.11a/ac standard is removed, as well
> > as code related to channel numbers above 14.
> >
> > VHT code is deleted as well, for it's related to 802.11ac.
> >
> > Comments are fixed accordingly and many unused variables are
> > deleted.
> >
> > Every single patch of this series has been tested on a
> > Lenovo Ideapad MIIX 300-10IBY except for the last one,
> > for obvious reason (it deletes just the TODO item).
>
> Thank you for your work on this. I've replied to 3 of
> the patches with some comments. The rest of the series
> looks ok to me (based on a quick scan of the patches).
>
> Regards,
>
> Hans
thank you, will improve what you pointed out
as soon as I figure out how to do it. See replies
to you reviews.
thank you,
fabio
>
>
>
> >
> > So:
> >
> > Tested-by: Fabio Auto <fabioaiuto83@...il.com>
> >
> > Fabio Aiuto (18):
> > staging: rtl8723bs: remove all 5Ghz network types
> > staging: rtl8723bs: remove code related to unsupported channel
> > bandwidth
> > staging: rtl8723bs: remove unused enum items related to channel
> > bonding
> > staging: rtl8723bs: rename enum items related to channel bonding
> > staging: rtl8723bs: remove 5Ghz field in struct registry_priv
> > staging: rtl8723bs: remove struct rt_channel_plan_5g
> > staging: rtl8723bs: remove all branchings between 2.4Ghz and 5Ghz band
> > types
> > staging: rtl8723bs: beautify prototypes in include/hal_com_phycfg.h
> > staging: rtl8723bs: remove 5Ghz code related to channel plan
> > definition
> > staging: rtl8723bs: remove some unused 5Ghz macro definitions
> > staging: rtl8723bs: remove 5Ghz code related to RF power calibration
> > staging: rtl8723bs: remove VHT dead code
> > staging: rtl8723bs: remove unused ODM_CMNINFO_BOARD_TYPE enum item
> > staging: rtl8723bs: fix macro value for 2.4Ghz only device
> > staging: rtl8723bs: remove register initializations tied to 802.11ac
> > standard
> > staging: rtl8723bs: remove obsolete 5Ghz comments
> > staging: rtl8723bs: fix check allowing 5Ghz settings
> > staging: rtl8723bs: remove item from TODO list
> >
> > drivers/staging/rtl8723bs/TODO | 2 -
> > drivers/staging/rtl8723bs/core/rtw_ap.c | 10 +-
> > .../staging/rtl8723bs/core/rtw_ieee80211.c | 22 +-
> > drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 -
> > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 328 ++---
> > .../staging/rtl8723bs/core/rtw_wlan_util.c | 29 +-
> > drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 +-
> > .../staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 4 +-
> > .../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 5 +-
> > drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h | 1 -
> > .../staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 17 +-
> > .../staging/rtl8723bs/hal/HalHWImg8723B_RF.c | 595 ++++-----
> > .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 19 +-
> > drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 -
> > drivers/staging/rtl8723bs/hal/hal_com.c | 241 ----
> > .../staging/rtl8723bs/hal/hal_com_phycfg.c | 1059 +++--------------
> > drivers/staging/rtl8723bs/hal/odm.c | 50 -
> > drivers/staging/rtl8723bs/hal/odm.h | 42 +-
> > drivers/staging/rtl8723bs/hal/odm_DIG.c | 2 -
> > .../rtl8723bs/hal/odm_EdcaTurboCheck.c | 4 +-
> > .../rtl8723bs/hal/odm_RegConfig8723B.c | 5 +-
> > .../rtl8723bs/hal/odm_RegConfig8723B.h | 2 -
> > drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 1 -
> > .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 53 +-
> > .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 43 +-
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c | 5 -
> > .../rtl8723bs/include/Hal8192CPhyReg.h | 2 -
> > drivers/staging/rtl8723bs/include/drv_types.h | 10 +-
> > drivers/staging/rtl8723bs/include/hal_com.h | 62 +-
> > .../rtl8723bs/include/hal_com_phycfg.h | 198 +--
> > .../staging/rtl8723bs/include/hal_com_reg.h | 1 -
> > drivers/staging/rtl8723bs/include/hal_data.h | 40 +-
> > drivers/staging/rtl8723bs/include/hal_pg.h | 2 -
> > drivers/staging/rtl8723bs/include/hal_phy.h | 10 -
> > drivers/staging/rtl8723bs/include/ieee80211.h | 67 +-
> > .../staging/rtl8723bs/include/rtl8723b_xmit.h | 21 -
> > drivers/staging/rtl8723bs/include/rtw_ht.h | 4 -
> > .../staging/rtl8723bs/include/rtw_mlme_ext.h | 52 +-
> > drivers/staging/rtl8723bs/include/rtw_rf.h | 33 +-
> > drivers/staging/rtl8723bs/include/wifi.h | 1 -
> > .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 -
> > .../staging/rtl8723bs/os_dep/ioctl_linux.c | 8 +-
> > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 13 +-
> > drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 4 -
> > 44 files changed, 640 insertions(+), 2450 deletions(-)
> >
>
Powered by blists - more mailing lists