linux-kernel - Re: [PATCH] usb: class: cdc-wdm: return the correct errno code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6122b97bb4a30a917b16837e8f98b6aac69f897a.camel@suse.com>
Date:   Mon, 21 Jun 2021 15:34:51 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Junlin Yang <angkery@....com>, gregkh@...uxfoundation.org,
        penguin-kernel@...ove.sakura.ne.jp, loic.poulain@...aro.org,
        davem@...emloft.net, lee.jones@...aro.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Junlin Yang <yangjunlin@...ong.com>
Subject: Re: [PATCH] usb: class: cdc-wdm: return the correct errno code

Am Montag, den 21.06.2021, 21:24 +0800 schrieb Junlin Yang:
> From: Junlin Yang <yangjunlin@...ong.com>
> 
> The "rv" is initialized to "-ENOMEM", because "rv" is re-assigned to
> "-EINVAL", when kmalloc & usb_alloc_urb failed, the return value
> should
> return "-ENOMEM" rather than "-EINVAL",so the "rv" assignment is
> placed
> in the position where usb_endpoint_is_int_in is false.
> 
> Signed-off-by: Junlin Yang <yangjunlin@...ong.com>
Acked-by: Oliver Neukum <oneukum@...e.com>