[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YNChySKddg/JsMZv@pendragon.ideasonboard.com>
Date: Mon, 21 Jun 2021 17:27:21 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Stefan Riedmüller <S.Riedmueller@...tec.de>
Cc: "daniel@...ll.ch" <daniel@...ll.ch>,
"airlied@...ux.ie" <airlied@...ux.ie>,
"sam@...nborg.org" <sam@...nborg.org>,
"thierry.reding@...il.com" <thierry.reding@...il.com>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO
G104SN02 V2 panel
Hi Stefan,
Thank you for the patch.
On Mon, Jun 21, 2021 at 08:22:10AM +0000, Stefan Riedmüller wrote:
> Hi,
>
> another gentle ping.
Sorry for the delay, I have way too little bandwidth these days :-S
> Also adding Laurent Pinchart to CC.
>
> On Wed, 2021-05-26 at 07:34 +0000, Stefan Riedmüller wrote:
> > On Thu, 2021-04-15 at 11:16 +0200, Stefan Riedmueller wrote:
> > > The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG.
> > > Add the corresponding connector type and 8 bpc as default bus_format.
> > >
> > > Signed-off-by: Stefan Riedmueller <s.riedmueller@...tec.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
It will be interesting to add support for the 6bpp mode at some point (I
assume through a custom DT property that reports the state of the
panel's SEL68 pin, as it should be strapped in most cases).
> > > ---
> > > drivers/gpu/drm/panel/panel-simple.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > > b/drivers/gpu/drm/panel/panel-simple.c
> > > index 4e2dad314c79..44583d0ed902 100644
> > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > @@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = {
> > > .width = 211,
> > > .height = 158,
> > > },
> > > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> > > + .connector_type = DRM_MODE_CONNECTOR_LVDS,
> > > };
> > >
> > > static const struct drm_display_mode auo_g121ean01_mode = {
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists