linux-kernel - Re: [PATCH v2] nitro_enclaves: Set Bus Master for the NE PCI device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1e75453-b7db-17c7-fc52-0d233073784c@amazon.com>
Date:   Mon, 21 Jun 2021 17:35:32 +0300
From:   "Paraschiv, Andra-Irina" <andraprs@...zon.com>
To:     "Longpeng(Mike)" <longpeng2@...wei.com>,
        <linux-kernel@...r.kernel.org>
CC:     <arei.gonglei@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexandru Vasile <lexnv@...zon.com>,
        Alexandru Ciobotaru <alcioa@...zon.com>
Subject: Re: [PATCH v2] nitro_enclaves: Set Bus Master for the NE PCI device



On 21/06/2021 03:40, Longpeng(Mike) wrote:
> Enable Bus Master for the NE PCI device, according to the PCI spec
> for submitting memory or I/O requests:
>
>   Master Enable – Controls the ability of a PCI Express
>    Endpoint to issue Memory and I/O Read/Write Requests, and
>    the ability of a Root or Switch Port to forward Memory and
>    I/O Read/Write Requests in the Upstream direction
>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Andra Paraschiv <andraprs@...zon.com>
> Cc: Alexandru Vasile <lexnv@...zon.com>
> Cc: Alexandru Ciobotaru <alcioa@...zon.com>
> Signed-off-by: Longpeng(Mike) <longpeng2@...wei.com>
> ---
> Changes since v1:
>    - update the commit message. [Andra]
> ---
>   drivers/virt/nitro_enclaves/ne_pci_dev.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/virt/nitro_enclaves/ne_pci_dev.c b/drivers/virt/nitro_enclaves/ne_pci_dev.c
> index b9c1de4..143207e 100644
> --- a/drivers/virt/nitro_enclaves/ne_pci_dev.c
> +++ b/drivers/virt/nitro_enclaves/ne_pci_dev.c
> @@ -480,6 +480,8 @@ static int ne_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>                  goto free_ne_pci_dev;
>          }
>
> +       pci_set_master(pdev);
> +
>          rc = pci_request_regions_exclusive(pdev, "nitro_enclaves");
>          if (rc < 0) {
>                  dev_err(&pdev->dev, "Error in pci request regions [rc=%d]\n", rc);
> --
> 1.8.3.1
>

Reviewed-by: Andra Paraschiv <andraprs@...zon.com>

Thank you.

Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.