linux-kernel - Re: [PATCH] spidev: add platform driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210621144135.GI4094@sirena.org.uk>
Date:   Mon, 21 Jun 2021 15:41:35 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Christian Gmeiner <christian.gmeiner@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, linux-spi@...r.kernel.org
Subject: Re: [PATCH] spidev: add platform driver support

On Mon, Jun 21, 2021 at 03:57:02PM +0200, Christian Gmeiner wrote:
> Am Mi., 16. Juni 2021 um 21:44 Uhr schrieb Mark Brown <broonie@...nel.org>:
> > On Wed, Jun 16, 2021 at 09:16:44PM +0200, Christian Gmeiner wrote:

> > I replied to your mail some time ago...

> It did not land in my in-box and I do not see your mail here:
> https://patches.linaro.org/patch/449250/

Speak to Linaro about their systems, they're nothing to do with me.

> In the end I found it only here:
> https://lore.kernel.org/lkml/YK9wDd%2F+c1uAjwk7@sirena.org.uk/

Lore provides links to download mboxes FWIW.

> The biggest pain point is that this system controller or the used FPGA
> can be updated via SPI. And
> I see no suitable subsystem to handle this update case.

> That's why I have chosen to expose the SPI device also via spidev.

OK, so you need a driver or subsystem that implements FPGA updates then
- depending on what that looks like the FPGA or MTD subsystems seem
likely to be candidates, or perhaps the MFD for your device should
provide something as part of the core functionality.  All the issues I
raised earlier apply here, spidev is rarely a good idea for production
use and certainly not in cases where there are actual drivers sharing
the device.

> > Please don't send content free pings and please allow a reasonable time
> > for review.  People get busy, go on holiday, attend conferences and so
> > on so unless there is some reason for urgency (like critical bug fixes)
> > please allow at least a couple of weeks for review.  If there have been
> > review comments then people may be waiting for those to be addressed.

> I am aware of the rules.. but as I told you I got nothing in my in-box
> for 2 weeks.

You need to take this up with your mail provider.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)