linux-kernel - RE: [PATCH v4] serial: samsung: change to platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000801d7665e$08424a00$18c6de00$@samsung.com>
Date:   Mon, 21 Jun 2021 10:56:45 +0530
From:   "M Tamseel Shams" <m.shams@...sung.com>
To:     <kgene@...nel.org>, <krzk@...nel.org>,
        <gregkh@...uxfoundation.org>, <jslaby@...e.com>
Cc:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <alim.akhtar@...sung.com>, <ajaykumar.rs@...sung.com>
Subject: RE: [PATCH v4] serial: samsung: change to platform_get_irq_optional



> -----Original Message-----
> From: Tamseel Shams <m.shams@...sung.com>
> Sent: Monday, June 21, 2021 10:18 AM
> To: kgene@...nel.org; krzk@...nel.org; gregkh@...uxfoundation.org;
> jslaby@...e.com
> Cc: linux-arm-kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org;
> linux-serial@...r.kernel.org; linux-kernel@...r.kernel.org;
> alim.akhtar@...sung.com; ajaykumar.rs@...sung.com; Tamseel Shams
> <m.shams@...sung.com>
> Subject: [PATCH v4] serial: samsung: change to platform_get_irq_optional
> 
> In few older Samsung SoCs like s3c2410, s3c2412 and s3c2440, UART IP is having
> 2 interrupt lines.
> However, in other SoCs like s3c6400, s5pv210, exynos5433, and exynos4210
> UART is having only 1 interrupt line. Due to this, "platform_get_irq(platdev, 1)"
> call in the driver gives the following false-positive error:
> "IRQ index 1 not found" on recent platforms.
> 
> This patch replaces the platform_get_irq() call with
> platform_get_irq_optional() and hence avoiding the false-positive error.
> 
> Signed-off-by: Tamseel Shams <m.shams@...sung.com>
> ---
> Commit message is changed.
> Addressed Krzysztof's previous comment.
> 
>  drivers/tty/serial/samsung_tty.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 6ef614d8648c..c44582011b9b 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -1911,7 +1911,7 @@ static int s3c24xx_serial_init_port(struct
> s3c24xx_uart_port *ourport,
>  		ourport->tx_irq = ret + 1;
>  	}
> 
> -	ret = platform_get_irq(platdev, 1);
> +	ret = platform_get_irq_optional(platdev, 1);
>  	if (ret > 0)
>  		ourport->tx_irq = ret;
>  	/*
> --
> 

Please ignore this patch.
Sorry for the spam.

Thanks & Regards,
Tamseel Shams