linux-kernel - Re: [PATCH] drivers/base/core: refcount kobject and bus on device attribute read / store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNJW+ZnoV5w8PZhm@kroah.com>
Date:   Tue, 22 Jun 2021 23:32:41 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     rafael@...nel.org, jeyu@...nel.org, ngupta@...are.org,
        sergey.senozhatsky.work@...il.com, minchan@...nel.org,
        axboe@...nel.dk, mbenes@...e.com, jpoimboe@...hat.com,
        tglx@...utronix.de, keescook@...omium.org, jikos@...nel.org,
        rostedt@...dmis.org, peterz@...radead.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/base/core: refcount kobject and bus on device
 attribute read / store

On Tue, Jun 22, 2021 at 02:06:59PM -0700, Luis Chamberlain wrote:
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -2039,31 +2039,68 @@ EXPORT_SYMBOL(dev_driver_string);
>  
>  #define to_dev_attr(_attr) container_of(_attr, struct device_attribute, attr)
>  
> +struct bus_type *bus_get(struct bus_type *bus);
> +void bus_put(struct bus_type *bus);
> +

Didn't checkpatch complain about this?

We have a local .h file for stuff like this, can you please use it?

thanks,

greg k-h