linux-kernel - Re: [PATCH] This patch replaces all the instances of dev_info with drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Jun 2021 08:40:26 +0200
From:   Christian König <christian.koenig@....com>
To:     Aman Jain <ahjain2706@...il.com>, alexander.deucher@....com,
        airlied@...ux.ie, daniel@...ll.ch, amd-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] This patch replaces all the instances of dev_info with
 drm_info macro

Am 22.06.21 um 08:07 schrieb Aman Jain:
> When a driver has multiple instances it is necessary to differentiate
> between them in the logs. This was done with dev_info/warn/err since
> DRM_INFO/WARN/ERROR don't do this. We now have drm_info/warn/err for
> printing the relevant debug messages. Hence, this patch uses
> drm_* macros to achieve drm-formatted logging

Well first of all patches for radeon should have a drm/radeon prefix in 
its subject line.

Then I don't think this patch makes sense since this is about the 
hardware support of the module and not even remotely drm related.

So we most likely don't want the drm-formating here in the first place.

Regards,
Christian.

>
> Signed-off-by: Aman Jain <ahjain2706@...il.com>
> ---
>   drivers/gpu/drm/radeon/radeon_drv.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index efeb115ae70e..75e84914c29b 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -308,7 +308,7 @@ static int radeon_pci_probe(struct pci_dev *pdev,
>   		case CHIP_VERDE:
>   		case CHIP_OLAND:
>   		case CHIP_HAINAN:
> -			dev_info(&pdev->dev,
> +			drm_info(&pdev->dev,
>   				 "SI support disabled by module param\n");
>   			return -ENODEV;
>   		}
> @@ -320,7 +320,7 @@ static int radeon_pci_probe(struct pci_dev *pdev,
>   		case CHIP_HAWAII:
>   		case CHIP_KABINI:
>   		case CHIP_MULLINS:
> -			dev_info(&pdev->dev,
> +			drm_info(&pdev->dev,
>   				 "CIK support disabled by module param\n");
>   			return -ENODEV;
>   		}