linux-kernel - RE: [SMBDIRECT][PATCH] missing rc checks while waiting for SMB3 over RDMA events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR21MB1506569FF2459DF87041EEC5CE099@BY5PR21MB1506.namprd21.prod.outlook.com>
Date:   Tue, 22 Jun 2021 06:49:26 +0000
From:   Long Li <longli@...rosoft.com>
To:     Steve French <smfrench@...il.com>
CC:     CIFS <linux-cifs@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: RE: [SMBDIRECT][PATCH] missing rc checks while waiting for SMB3 over
 RDMA events

> Subject: [SMBDIRECT][PATCH] missing rc checks while waiting for SMB3 over
> RDMA events
> 
>     There were two places where we weren't checking for error
>     (e.g. ERESTARTSYS) while waiting for rdma resolution.
> 
>     Addresses-Coverity: 1462165 ("Unchecked return value")
>    Signed-off-by: Steve French <stfrench@...rosoft.com>
> 
> diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c index
> 10dfe5006792..ae07732f750f 100644
> --- a/fs/cifs/smbdirect.c
> +++ b/fs/cifs/smbdirect.c
> @@ -572,8 +572,11 @@ static struct rdma_cm_id *smbd_create_id(
>                 log_rdma_event(ERR, "rdma_resolve_addr() failed %i\n", rc);
>                 goto out;
>         }
> -       wait_for_completion_interruptible_timeout(
> +       rc = wait_for_completion_interruptible_timeout(
>                 &info->ri_done, msecs_to_jiffies(RDMA_RESOLVE_TIMEOUT));
> +       /* -ERESTARTSYS, returned when interrupted, is the only rc mentioned
> */
> +       if (rc < 0)
> +               goto out;
>         rc = info->ri_rc;
>         if (rc) {
>                 log_rdma_event(ERR, "rdma_resolve_addr() completed %i\n", rc);
> @@ -586,8 +589,10 @@ static struct rdma_cm_id *smbd_create_id(
>                 log_rdma_event(ERR, "rdma_resolve_route() failed %i\n", rc);
>                 goto out;
>         }
> -       wait_for_completion_interruptible_timeout(
> +       rc = wait_for_completion_interruptible_timeout(
>                 &info->ri_done, msecs_to_jiffies(RDMA_RESOLVE_TIMEOUT));
> +       if (rc < 0)  /* e.g. if interrupted and returns -ERESTARTSYS */
> +               goto out
>         rc = info->ri_rc;
>         if (rc) {
>                 log_rdma_event(ERR, "rdma_resolve_route() completed %i\n", rc);
> 
> 
> --
> Thanks,
> 
> Steve

Reviewed-by: Long Li <longli@...rosoft.com>