linux-kernel - Re: [PATCH 12/18] staging: rtl8723bs: remove VHT dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210622095757.GB1426@agape.jhs>
Date:   Tue, 22 Jun 2021 11:57:57 +0200
From:   Fabio Aiuto <fabioaiuto83@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/18] staging: rtl8723bs: remove VHT dead code

On Tue, Jun 22, 2021 at 11:19:36AM +0200, Hans de Goede wrote:

Hi Hans,

> Hi Fabio,
> 
> > Moreover I have been quite conservative, for I left untouched HT indexes above
> > 7 which rtl8723bs doesn't support.
> > 
> > So IMO I think this patch is fine as is...
> >> Perhaps this entire block can never be executed ?
> > 
> > the block is executed but there's no register write happening. Just
> > updating of values which will never be fetched.
> 
> Ack, my bad I was under the impression that phy_SetTxPowerByRateBase()
> would actually do a register write, but I checked and it just updates
> some unused table values, so dropping this code is fine and you can
> keep this patch for v2 of the patch set.
> 
> Regards,
> 
> Hans
> 

thank you, what do you think about what I replied about patch 1, shall
I remove the '> 14 if block' or leave it as is? Do you think is necessary
to keep the conditions inside the block and pack them?

I would leave as is but is my opinion...

regards,

fabio