linux-kernel - Re: [patch V3 33/66] x86/fpu: Rename copy_fpregs_to_fpstate() to save_fpregs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNG4dGnYGMJOTSFO@zn.tnic>
Date:   Tue, 22 Jun 2021 12:16:20 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Kan Liang <kan.liang@...ux.intel.com>
Subject: Re: [patch V3 33/66] x86/fpu: Rename copy_fpregs_to_fpstate() to
 save_fpregs_to_fpstate()

On Fri, Jun 18, 2021 at 04:18:56PM +0200, Thomas Gleixner wrote:
> A copy is guaranteed to leave the source intact, which is not the case when
> FNSAVE is used as that reinitilizes the registers.
> 
> Save does not make such guarantees and it matches what this is about,
> i.e. to save the state for a later restore.
> 
> Rename it to save_fpregs_to_fpstate(). 
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
>  arch/x86/include/asm/fpu/internal.h |    4 ++--
>  arch/x86/kernel/fpu/core.c          |   10 +++++-----
>  arch/x86/kvm/x86.c                  |    2 +-
>  3 files changed, 8 insertions(+), 8 deletions(-)

Reviewed-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg