linux-kernel - Re: [PATCH 4/6] iommu: Combine device strictness requests with the global default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a86c2f9c-f66a-3a12-cf80-6e3fc6dafda4@linux.intel.com>
Date:   Tue, 22 Jun 2021 10:03:45 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Douglas Anderson <dianders@...omium.org>,
        gregkh@...uxfoundation.org, rafael@...nel.org,
        rafael.j.wysocki@...el.com, will@...nel.org, robin.murphy@....com,
        joro@...tes.org, bjorn.andersson@...aro.org,
        ulf.hansson@...aro.org, adrian.hunter@...el.com,
        bhelgaas@...gle.com
Cc:     baolu.lu@...ux.intel.com, robdclark@...omium.org,
        linux-kernel@...r.kernel.org, saravanak@...gle.com,
        linux-arm-msm@...r.kernel.org, linux-mmc@...r.kernel.org,
        quic_c_gdjako@...cinc.com, iommu@...ts.linux-foundation.org,
        linux-pci@...r.kernel.org, joel@...lfernandes.org,
        rajatja@...gle.com, sonnyrao@...omium.org, vbadigan@...eaurora.org
Subject: Re: [PATCH 4/6] iommu: Combine device strictness requests with the
 global default

On 6/22/21 7:52 AM, Douglas Anderson wrote:
> @@ -1519,7 +1542,8 @@ static int iommu_get_def_domain_type(struct device *dev)
>   
>   static int iommu_group_alloc_default_domain(struct bus_type *bus,
>   					    struct iommu_group *group,
> -					    unsigned int type)
> +					    unsigned int type,
> +					    struct device *dev)
>   {
>   	struct iommu_domain *dom;
>   
> @@ -1534,6 +1558,12 @@ static int iommu_group_alloc_default_domain(struct bus_type *bus,
>   	if (!dom)
>   		return -ENOMEM;
>   
> +	/* Save the strictness requests from the device */
> +	if (dev && type == IOMMU_DOMAIN_DMA) {
> +		dom->request_non_strict = dev->request_non_strict_iommu;
> +		dom->force_strict = dev->force_strict_iommu;
> +	}
> +

An iommu default domain might be used by multiple devices which might
have different "strict" attributions. Then who could override who?

Best regards,
baolu