linux-kernel - Re: [PATCH 2/2] regulator: da9052: Simplify checking DVC controlled regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210622125024.GC4574@sirena.org.uk>
Date:   Tue, 22 Jun 2021 13:50:24 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Axel Lin <axel.lin@...ics.com>
Cc:     Philipp Zabel <p.zabel@...gutronix.de>,
        Steve Twiss <stwiss.opensource@...semi.com>,
        Support Opensource <support.opensource@...semi.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regulator: da9052: Simplify checking DVC controlled
 regulators

On Fri, Jun 18, 2021 at 10:14:12PM +0800, Axel Lin wrote:

> Only DVC controlled regulators have activate_bit set, so just check
> activate_bit we can know if the regulator is DVC controlled.

This feels a bit icky - what if the activate_bit for some variant were
bit 0?  I'm not sure we're likely to see new variants but even so the
fact that 0 is a potentially valid value for the bit feels wrong.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)