linux-kernel - Re: [PATCHv5 5/5] misc: gehc-achc: new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2CmYnE=S8RqxM-3bKYH+VvYxOpA2-jzBLYwftvvA614Q@mail.gmail.com>
Date:   Tue, 22 Jun 2021 15:37:49 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     kernel test robot <lkp@...el.com>
Cc:     Sebastian Reichel <sebastian.reichel@...labora.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, kbuild-all@...ts.01.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>, Ian Ray <ian.ray@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-spi <linux-spi@...r.kernel.org>
Subject: Re: [PATCHv5 5/5] misc: gehc-achc: new driver

On Tue, Jun 22, 2021 at 3:30 PM kernel test robot <lkp@...el.com> wrote:
>
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/misc/nxp-ezport.o
> >> ERROR: modpost: "ezport_flash" [drivers/misc/gehc-achc.ko] undefined!
> >> ERROR: modpost: "ezport_reset" [drivers/misc/gehc-achc.ko] undefined!

It looks like this was only tested as a built-in driver. The easiest way would
be to change the Makefile to link both files into a combined driver module,
such as

obj-$(CONFIG_GEHC_ACHC)           += gehc-achc-mod.o
gehc-achc-mod.o                                += gehc-achc.o nxp-ezport.o

       Arnd