linux-kernel - Re: [PATCH 3/4] MIPS: GCW0: Adjust pinctrl related code in device tree.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1HW3VQ.OQVPDYR5D5RR1@opendingux.net>
Date:   Tue, 22 Jun 2021 15:05:25 +0100
From:   Paul Cercueil <paul@...ndingux.net>
To:     周琰杰 <zhouyanjie@...yeetech.com>
Cc:     tsbogend@...ha.franken.de, robh+dt@...nel.org,
        linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, dongsheng.qiu@...enic.com,
        aric.pzqi@...enic.com, rick.tyliu@...enic.com,
        sihui.liu@...enic.com, jun.jiang@...enic.com,
        sernia.zhou@...mail.com
Subject: Re: [PATCH 3/4] MIPS: GCW0: Adjust pinctrl related code in device
 tree.

Hi Zhou,

Le mar., juin 22 2021 at 21:51:19 +0800, 周琰杰 
<zhouyanjie@...yeetech.com> a écrit :
> Hi Paul,
> 
> 于 Tue, 22 Jun 2021 13:46:57 +0100
> Paul Cercueil <paul@...ndingux.net> 写道:
> 
>>  Hi Zhou,
>> 
>>  Le mar., juin 22 2021 at 15:37:24 +0800, 周琰杰 (Zhou Yanjie)
>>  <zhouyanjie@...yeetech.com> a écrit :
>>  > Change the "lcd-24bit" in the pinctrl groups to "lcd-8bit",
>>  > "lcd-16bit", "lcd-18bit", "lcd-24bit", since the pinctrl
>>  > driver has done the necessary splitting of the lcd group,
>>  > and it is convenient to further streamline the lcd-24bit
>>  > group in the subsequent pinctrl driver.
>>  >
>>  > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
>>  > ---
>>  >  arch/mips/boot/dts/ingenic/gcw0.dts | 2 +-
>>  >  1 file changed, 1 insertion(+), 1 deletion(-)
>>  >
>>  > diff --git a/arch/mips/boot/dts/ingenic/gcw0.dts
>>  > b/arch/mips/boot/dts/ingenic/gcw0.dts
>>  > index f4c04f2..dec3ba6f 100644
>>  > --- a/arch/mips/boot/dts/ingenic/gcw0.dts
>>  > +++ b/arch/mips/boot/dts/ingenic/gcw0.dts
>>  > @@ -393,7 +393,7 @@
>>  >  &pinctrl {
>>  >  	pins_lcd: lcd {
>>  >  		function = "lcd";
>>  > -		groups = "lcd-24bit";
>>  > +		groups = "lcd-8bit", "lcd-16bit", "lcd-18bit",
>>  > "lcd-24bit";
>> 
>>  No, I'm pretty sure this won't work, since "lcd-24bit" contains pins
>>  that are also contained by the other groups.
>> 
> 
> Sure, it seems that we should modify the pinctrl first, then modify 
> the
> dts, and then put them in the same series, so as to ensure that they 
> do
> not cause damage.

No, the "lcd-24bit" group is ABI now. We can't change it...

-Paul

> 
> Thanks and best regards!
> 
>>  -Paul
>> 
>>  >  	};
>>  >
>>  >  	pins_uart2: uart2 {
>>  > --
>>  > 2.7.4
>>  >
>> 
>