linux-kernel - Re: [PATCH] pci: hda: Add IRQ check for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNHu8GxbzYStfj4W@orome.fritz.box>
Date:   Tue, 22 Jun 2021 16:08:48 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Jiajun Cao <jjcao20@...an.edu.cn>
Cc:     yuanxzhang@...an.edu.cn, Xin Tan <tanxin.ctf@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Dmitry Osipenko <digetx@...il.com>,
        Mohan Kumar <mkumard@...dia.com>,
        Peter Geis <pgwipeout@...il.com>, alsa-devel@...a-project.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci: hda: Add IRQ check for platform_get_irq()

On Tue, Jun 22, 2021 at 09:19:42PM +0800, Jiajun Cao wrote:
> The function hda_tegra_first_init() neglects to check the return
> value after executing platform_get_irq().
> 
> hda_tegra_first_init() should check the return value (if negative
> error number) for errors so as to not pass a negative value to
> the devm_request_irq().
> 
> Fix it by adding a check for the return value irq_id.
> 
> Signed-off-by: Jiajun Cao <jjcao20@...an.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@...il.com>
> ---
>  sound/pci/hda/hda_tegra.c | 3 +++
>  1 file changed, 3 insertions(+)

The original code is probably harmless because it looks like the call to
request_irq() would return -EINVAL if irq_id was a negative error code.

But checking the return value is still a good idea, so:

Reviewed-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)