linux-kernel - Re: [PATCH] interconnect: qcom: icc-rpmh: Consolidate probe functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YNEp1kTcsqRs39tj@google.com>
Date:   Mon, 21 Jun 2021 17:07:50 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Mike Tipton <mdtipton@...eaurora.org>
Cc:     djakov@...nel.org, bjorn.andersson@...aro.org, agross@...nel.org,
        okukatla@...eaurora.org, linux-pm@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] interconnect: qcom: icc-rpmh: Consolidate probe functions

On Mon, Jun 21, 2021 at 02:42:41PM -0700, Mike Tipton wrote:
> The current probe/remove functions are implemented separately for each
> target, but they are almost identical. Replace them with common
> functions that can be used across all rpmh targets.
> 
> Signed-off-by: Mike Tipton <mdtipton@...eaurora.org>

Good catch, the code is indeed very redundant.

Reviewed-by: Matthias Kaehlcke <mka@...omium.org>