linux-kernel - Re: [PATCH] ath11k: Avoid memcpy() over-reading of he

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Jun 2021 15:28:14 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     netdev@...r.kernel.org, Kees Cook <keescook@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org,
        ath11k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ath11k: Avoid memcpy() over-reading of he_cap

Kees Cook <keescook@...omium.org> wrote:

> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memcpy(), memmove(), and memset(), avoid
> intentionally writing across neighboring array fields.
> 
> Since peer_he_cap_{mac,phy}info and he_cap_elem.{mac,phy}_cap_info are not
> the same sizes, memcpy() was reading beyond field boundaries. Instead,
> correctly cap the copy length and pad out any difference in size
> (peer_he_cap_macinfo is 8 bytes whereas mac_cap_info is 6, and
> peer_he_cap_phyinfo is 12 bytes whereas phy_cap_info is 11).
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Kalle Valo <kvalo@...eaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

c8bcd82a4efd ath11k: Avoid memcpy() over-reading of he_cap

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210616195410.1232119-1-keescook@chromium.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches