linux-kernel - Re: [PATCH 00/54] KVM: x86/mmu: Bug fixes and summer cleaning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Jun 2021 22:29:55 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Yu Zhang <yu.c.zhang@...ux.intel.com>,
        Maxim Levitsky <mlevitsk@...hat.com>
Subject: Re: [PATCH 00/54] KVM: x86/mmu: Bug fixes and summer cleaning

On 22/06/21 19:56, Sean Christopherson wrote:
> Patch 01 is the only patch that is remotely 5.13 worthy, and even then
> only because it's about as safe as a patch can be.  Everything else is far
> from urgent as these bugs have existed for quite some time.

Maybe patch 54 (not sarcastic), but I agree it's not at all necessary.

This is good stuff, I made a few comments but almost all of them (all 
except the last comment on patch 9, "Unconditionally zap unsync SPs") 
are cosmetic and I can resolve them myself.

I'd like your input on renaming is_{cr0,cr4,efer}_* to is_mmu_* (and 
possibly reduce the four underscores to two...).

If I get remarks by tomorrow, I'll get this into 5.14, otherwise 
consider everything but the first eight patches queued only for 5.15.

> I labeled the "sections" of this mess in the shortlog below.
> 
> P.S. Does anyone know how PKRU interacts with NPT?  I assume/hope NPT
>       accesses, which are always "user", ignore PKRU, but the APM doesn't
>       say a thing.  If PKRU is ignored, KVM has some fixing to do.  If PKRU
>       isn't ignored, AMD has some fixing to do:-)
> 
> P.S.S. This series pulled in one patch from my vCPU RESET/INIT series,
>         "Properly reset MMU context at vCPU RESET/INIT", as that was needed
>         to fix a root_level bug on VMX.  My goal is to get the RESET/INIT
>         series refreshed later this week and thoroughly bombard everyone.

Note that it won't get into 5.14 anyway, since I plan to send my first 
pull request to Linus as soon as Friday.

Paolo