linux-kernel - Re: [PATCH 25/54] KVM: x86/mmu: Add helpers to query mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c1cc822-4604-9e04-dd4c-e5005bfee7c5@redhat.com>
Date:   Wed, 23 Jun 2021 22:53:02 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Yu Zhang <yu.c.zhang@...ux.intel.com>,
        Maxim Levitsky <mlevitsk@...hat.com>
Subject: Re: [PATCH 25/54] KVM: x86/mmu: Add helpers to query mmu_role bits

On 23/06/21 22:47, Sean Christopherson wrote:
>> What do you think about calling these is_mmu_##name?  The point of having
>> these helpers is that the register doesn't count, and they return the
>> effective value (e.g. false in most EPT cases).
>
> I strongly prefer to keep <reg> in the name, both to match the mmu_role bits and
> to make it a bit more clear that it's reflective (modified) register state, as
> opposed to PTEs or even something else entirely.  E.g. I always struggled to
> remember the purpose of mmu->nx flag.

No problem.  I do disagree that it's register state ("modified" seems to 
be more than a parenthetical remark), but not enough to argue about it 
and even less to do the work to rename the accessors.

Paolo