linux-kernel - Re: [PATCH v2 05/10] block: reduce stack footprint dealing with block device names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNLmfsrS6RIFBX/n@infradead.org>
Date:   Wed, 23 Jun 2021 08:45:02 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Anton Suvorov <warwish@...dex-team.ru>
Cc:     willy@...radead.org, dmtrmonakhov@...dex-team.ru,
        linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk
Subject: Re: [PATCH v2 05/10] block: reduce stack footprint dealing with
 block device names

On Tue, Jun 22, 2021 at 08:44:19PM +0300, Anton Suvorov wrote:
> Stack usage reduced (measured with allyesconfig):

Not just stack footprint, but also a whole lot cleaner code in general.

> -			       bdevname(state->bdev, b), blk);
> +			pr_err("Dev %pg: unable to read RDB block %d\n", state->bdev, blk);

> -		       bdevname(state->bdev, b), blk);
> +		pr_err("Dev %pg: RDB in block %d has bad checksum\n", state->bdev, blk);

> -			pr_err("Dev %s: unable to read partition block %d\n",
> -			       bdevname(state->bdev, b), blk);
> +			pr_err("Dev %pg: unable to read partition block %d\n", state->bdev, blk);

[...]

Please keep the non-format string arguments on separate lines instead
of creating unreadable lines.