linux-kernel - Re: [PATCH 6/8] dt-bindings: mediatek: mt8195: add audio afe document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8344d089562052a6f9ee3245856bbc8516bb6619.camel@mediatek.com>
Date:   Wed, 23 Jun 2021 16:10:56 +0800
From:   Trevor Wu <trevor.wu@...iatek.com>
To:     Rob Herring <robh@...nel.org>
CC:     <devicetree@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <broonie@...nel.org>, <bicycle.tsai@...iatek.com>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <robh+dt@...nel.org>,
        <cychiang@...gle.com>, <jiaxin.yu@...iatek.com>, <tiwai@...e.com>,
        <matthias.bgg@...il.com>
Subject: Re: [PATCH 6/8] dt-bindings: mediatek: mt8195: add audio afe
 document

On Thu, 2021-06-17 at 15:26 -0600, Rob Herring wrote:
> On Thu, 17 Jun 2021 13:47:37 +0800, Trevor Wu wrote:
> > This patch adds mt8195 audio afe document.
> > 
> > Signed-off-by: Trevor Wu <trevor.wu@...iatek.com>
> > ---
> >  .../bindings/sound/mt8195-afe-pcm.yaml        | 72
> > +++++++++++++++++++
> >  1 file changed, 72 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/sound/mt8195-
> > afe-pcm.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/sound/mt8195-afe-pcm.yaml:10:4:
> [warning] wrong indentation: expected 2 but found 3 (indentation)
> ./Documentation/devicetree/bindings/sound/mt8195-afe-pcm.yaml:14:7:
> [warning] wrong indentation: expected 4 but found 6 (indentation)
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/sound/mt8195-afe-
> pcm.example.dts:19:18: fatal error: dt-bindings/clock/mt8195-clk.h:
> No such file or directory
>    19 |         #include <dt-bindings/clock/mt8195-clk.h>
>       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[1]: *** [scripts/Makefile.lib:380:
> Documentation/devicetree/bindings/sound/mt8195-afe-
> pcm.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1416: dt_binding_check] Error 2
> \ndoc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/patch/1493197
> 
> This check can fail if there are any dependencies. The base for a
> patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up
> to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
> 

Sorry, I missed the dependency declaration in the patch and I didn't
install ymallint, so I couldn't find indentation problems.
I will fix all binding problems on v2.

Thanks,
Trevor