| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202106231618.AAdUP8Wx-lkp@intel.com>
Date: Wed, 23 Jun 2021 16:29:11 +0800
From: kernel test robot <lkp@...el.com>
To: 13145886936@....com, davem@...emloft.net, kuba@...nel.org
Cc: kbuild-all@...ts.01.org, linux-decnet-user@...ts.sourceforge.net,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
gushengxian <gushengxian@...ong.com>
Subject: Re: [PATCH] decnet: af_decnet: pmc should not be referenced when
it's NULL
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on net/master linus/master v5.13-rc7 next-20210622]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/13145886936-163-com/decnet-af_decnet-pmc-should-not-be-referenced-when-it-s-NULL/20210623-113728
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 38f75922a6905b010f597fc70dbb5db28398728e
config: ia64-randconfig-r005-20210622 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/684dced1c59e94a4ef160061073d0cb928b370e4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review 13145886936-163-com/decnet-af_decnet-pmc-should-not-be-referenced-when-it-s-NULL/20210623-113728
git checkout 684dced1c59e94a4ef160061073d0cb928b370e4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
net/decnet/af_decnet.c: In function 'dn_ioctl':
>> net/decnet/af_decnet.c:1240:3: error: expected expression before '}' token
1240 | }
| ^
vim +1240 net/decnet/af_decnet.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1203
^1da177e4c3f41 Linus Torvalds 2005-04-16 1204 static int dn_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1205 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1206 struct sock *sk = sock->sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1207 struct dn_scp *scp = DN_SK(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1208 int err = -EOPNOTSUPP;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1209 long amount = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1210 struct sk_buff *skb;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1211 int val;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1212
684dced1c59e94 gushengxian 2021-06-22 1213 switch (cmd) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1214 case SIOCGIFADDR:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1215 case SIOCSIFADDR:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1216 return dn_dev_ioctl(cmd, (void __user *)arg);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1217
^1da177e4c3f41 Linus Torvalds 2005-04-16 1218 case SIOCATMARK:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1219 lock_sock(sk);
b03efcfb218028 David S. Miller 2005-07-08 1220 val = !skb_queue_empty(&scp->other_receive_queue);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1221 if (scp->state != DN_RUN)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1222 val = -ENOTCONN;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1223 release_sock(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1224 return val;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1225
^1da177e4c3f41 Linus Torvalds 2005-04-16 1226 case TIOCOUTQ:
31e6d363abcd0d Eric Dumazet 2009-06-17 1227 amount = sk->sk_sndbuf - sk_wmem_alloc_get(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1228 if (amount < 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1229 amount = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1230 err = put_user(amount, (int __user *)arg);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1231 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1232
^1da177e4c3f41 Linus Torvalds 2005-04-16 1233 case TIOCINQ:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1234 lock_sock(sk);
e57c624be8f99e Hannes Eder 2009-02-25 1235 skb = skb_peek(&scp->other_receive_queue);
e57c624be8f99e Hannes Eder 2009-02-25 1236 if (skb) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1237 amount = skb->len;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1238 } else {
bec571ec762a4c David S. Miller 2009-05-28 1239 skb_queue_walk(&sk->sk_receive_queue, skb)
^1da177e4c3f41 Linus Torvalds 2005-04-16 @1240 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1241 release_sock(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1242 err = put_user(amount, (int __user *)arg);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1243 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1244
^1da177e4c3f41 Linus Torvalds 2005-04-16 1245 default:
b5e5fa5e093e42 Christoph Hellwig 2006-01-03 1246 err = -ENOIOCTLCMD;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1247 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1248 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1249
^1da177e4c3f41 Linus Torvalds 2005-04-16 1250 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1251 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1252
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (30874 bytes)
Powered by blists - more mailing lists