linux-kernel - Re: [PATCH] dmaengine: xilinx: dpdma: Fix spacing around addr[i-1]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNMwGICbXY2pWhwn@pendragon.ideasonboard.com>
Date:   Wed, 23 Jun 2021 15:59:04 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu, git@...inx.com,
        Hyun Kwon <hyun.kwon@...inx.com>,
        Vinod Koul <vkoul@...nel.org>, dmaengine@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] dmaengine: xilinx: dpdma: Fix spacing around addr[i-1]

On Wed, Jun 23, 2021 at 01:07:38PM +0200, Michal Simek wrote:
> Use proper spacing for array calculation. Issue is reported by
> checkpatch.pl --strict.
> 
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
> 
>  drivers/dma/xilinx/xilinx_dpdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index 0b67083c95d0..b280a53e8570 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -531,7 +531,7 @@ static void xilinx_dpdma_sw_desc_set_dma_addrs(struct xilinx_dpdma_device *xdev,
>  	for (i = 1; i < num_src_addr; i++) {
>  		u32 *addr = &hw_desc->src_addr2;
>  
> -		addr[i-1] = lower_32_bits(dma_addr[i]);
> +		addr[i - 1] = lower_32_bits(dma_addr[i]);

I don't mind either way.

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

>  
>  		if (xdev->ext_addr) {
>  			u32 *addr_ext = &hw_desc->addr_ext_23;

-- 
Regards,

Laurent Pinchart