| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <74ef13b2-ed97-1386-f6ea-5b041e68fe92@redhat.com>
Date: Wed, 23 Jun 2021 15:07:21 +0200
From: Paolo Bonzini <pbonzini@...hat.com>
To: Sean Christopherson <seanjc@...gle.com>,
Christian Borntraeger <borntraeger@...ibm.com>,
Janosch Frank <frankja@...ux.ibm.com>
Cc: David Hildenbrand <david@...hat.com>,
Cornelia Huck <cohuck@...hat.com>,
Claudio Imbrenda <imbrenda@...ux.ibm.com>, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org, Peter Xu <peterx@...hat.com>,
Peter Shier <pshier@...gle.com>
Subject: Re: [PATCH 00/19] KVM: selftests: Add x86 mmu_role test and cleanups
On 22/06/21 22:05, Sean Christopherson wrote:
> The primary intent of this series is to allow x86-64 tests to create
> arbitrary hugepages and use the new functionality to abuse x86's CPUID
> APIs to test KVM MMU behavior.
>
> The majority of the prep work refactors the selftests APIs related to
> memory allocation. The core memory allocation APIs within the selftests
> don't provide defaults for memslot or min virtual address, which has led
> to a ridiculous amount of magic and duplicate code. Literally zero tests
> use non-standard values in a meaningful way, and if a test comes along
> that has a legitimate use case, it should use lower-level helpers.
>
> Patches 01 and 02 are fixes for bugs found during the refactoring.
>
> As for the mmu_role test itself, the idea is to change the vCPU model
> while the guest is running (via KVM_SET_CPUID2) to verify that KVM
> reconfigures its MMUs when the vCPU model is changed. E.g. toggling
> guest support for 1gb hugepages and changing guest MAXPHYADDR.
>
> Sadly, the test doesn't pass when KVM is using TDP paging (even with all
> my mmu_role fixes) because KVM doesn't fully support manipulating GBPAGES
> and MAXPHYADDR (and other CPUID-based properties that affect the MMU)
> while the guest is running. And practically speaking, KVM will never
> fully support such behavior becuase (a) there is likely no sane use case,
> (b) fixing the issues is very costly (memory consumption), (c) GBPAGES
> and potentially other features _can't_ be handled correctly due to lack
> of hardware support, and (d) userspace can workaround all issues simply
> by deleting a memslot.
>
> All that said, I purposely made the test off-by-default instead of
> requiring TDP. Partly because detecting whether TDP is enabled is a pain
> becuase it's per-vendor, but also because running the test with TDP
> enabled is still interesting to some extent, e.g. the test will fail, but
> it shouldn't crash KVM, trigger WARNs, etc...
>
> Sean Christopherson (19):
> KVM: selftests: Remove errant asm/barrier.h include to fix arm64 build
> KVM: selftests: Zero out the correct page in the Hyper-V features test
> KVM: selftests: Unconditionally use memslot 0 when loading elf binary
> KVM: selftests: Unconditionally use memslot 0 for x86's GDT/TSS setup
> KVM: selftests: Use "standard" min virtual address for Hyper-V pages
> KVM: selftests: Add helpers to allocate N pages of virtual memory
> KVM: selftests: Lower the min virtual address for misc page
> allocations
> KVM: selftests: Use alloc_page helper for x86-64's GDT/ITD/TSS
> allocations
> KVM: selftests: Use alloc page helper for xAPIC IPI test
> KVM: selftests: Use "standard" min virtual address for CPUID test
> alloc
> KVM: selftest: Unconditionally use memslot 0 for vaddr allocations
> KVM: selftests: Unconditionally use memslot '0' for page table
> allocations
> KVM: selftests: Unconditionally allocate EPT tables in memslot 0
> KVM: selftests: Add wrapper to allocate page table page
> KVM: selftests: Rename x86's page table "address" to "pfn"
> KVM: selfests: Add PTE helper for x86-64 in preparation for hugepages
> KVM: selftests: Genericize upper level page table entry struct
> KVM: selftests: Add hugepage support for x86-64
> KVM: sefltests: Add x86-64 test to verify MMU reacts to CPUID updates
>
> tools/testing/selftests/kvm/.gitignore | 1 +
> tools/testing/selftests/kvm/Makefile | 1 +
> tools/testing/selftests/kvm/dirty_log_test.c | 5 +-
> .../selftests/kvm/hardware_disable_test.c | 2 +-
> .../testing/selftests/kvm/include/kvm_util.h | 18 +-
> .../selftests/kvm/include/x86_64/processor.h | 11 +
> .../selftests/kvm/include/x86_64/vmx.h | 10 +-
> .../selftests/kvm/kvm_page_table_test.c | 2 +-
> .../selftests/kvm/lib/aarch64/processor.c | 34 +--
> .../testing/selftests/kvm/lib/aarch64/ucall.c | 2 +-
> tools/testing/selftests/kvm/lib/elf.c | 6 +-
> tools/testing/selftests/kvm/lib/kvm_util.c | 62 ++++-
> .../selftests/kvm/lib/perf_test_util.c | 2 +-
> .../selftests/kvm/lib/s390x/processor.c | 17 +-
> .../selftests/kvm/lib/x86_64/processor.c | 254 ++++++++----------
> tools/testing/selftests/kvm/lib/x86_64/svm.c | 9 +-
> tools/testing/selftests/kvm/lib/x86_64/vmx.c | 52 ++--
> .../testing/selftests/kvm/memslot_perf_test.c | 2 +-
> .../selftests/kvm/set_memory_region_test.c | 2 +-
> tools/testing/selftests/kvm/steal_time.c | 2 +-
> .../selftests/kvm/x86_64/get_cpuid_test.c | 3 +-
> .../selftests/kvm/x86_64/hyperv_clock.c | 2 +-
> .../selftests/kvm/x86_64/hyperv_features.c | 8 +-
> .../selftests/kvm/x86_64/mmu_role_test.c | 147 ++++++++++
> .../selftests/kvm/x86_64/set_boot_cpu_id.c | 2 +-
> .../kvm/x86_64/vmx_apic_access_test.c | 2 +-
> .../selftests/kvm/x86_64/vmx_dirty_log_test.c | 8 +-
> .../selftests/kvm/x86_64/xapic_ipi_test.c | 4 +-
> .../selftests/kvm/x86_64/xen_shinfo_test.c | 2 +-
> .../selftests/kvm/x86_64/xen_vmcall_test.c | 2 +-
> 30 files changed, 414 insertions(+), 260 deletions(-)
> create mode 100644 tools/testing/selftests/kvm/x86_64/mmu_role_test.c
>
Queued, thanks.
Paolo
Powered by blists - more mailing lists