linux-kernel - Re: [RFC PATCH 3/4] cpufreq: Add Active Stats calls tracking frequency changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210623031517.tldkue7dcx4bt7gn@vireshk-i7>
Date:   Wed, 23 Jun 2021 08:45:17 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Lukasz Luba <lukasz.luba@....com>
Cc:     linux-kernel@...r.kernel.org, daniel.lezcano@...aro.org,
        linux-pm@...r.kernel.org, amitk@...nel.org, rui.zhang@...el.com,
        dietmar.eggemann@....com, Chris.Redpath@....com,
        Beata.Michalska@....com, rjw@...ysocki.net, amit.kachhap@...il.com
Subject: Re: [RFC PATCH 3/4] cpufreq: Add Active Stats calls tracking
 frequency changes

On 22-06-21, 12:07, Lukasz Luba wrote:
> That cpufreq_stats_record_transition() is present only if
> CONFIG_CPU_FREQ_STAT is set. I didn't wanted to be dependent on
> this config.

Right, but you can also update the dummy
cpufreq_stats_record_transition() function as well and you won't
depend on the CONFIG then.

> > 
> > Plus don't you need to record this for all policy->cpus instead of
> > just policy->cpu ?
> > 
> 
> It will be accounted for all cpus in that freq domain. The
> active_stats_cpu_freq_fast_change() implementation uses
> a shared structure (single for whole domain) 'shared_ast':
> _active_stats_cpu_freq_change(ast->shared_ast, freq, ts)
> (from patch 1/4)

Ahh, I missed that then.

-- 
viresh