linux-kernel - Re: [PATCH] usb: host: ohci-at91: suspend/resume ports after/before OHCI accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210623164148.GC499969@rowland.harvard.edu>
Date:   Wed, 23 Jun 2021 12:41:48 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Claudiu.Beznea@...rochip.com
Cc:     gregkh@...uxfoundation.org, Nicolas.Ferre@...rochip.com,
        alexandre.belloni@...tlin.com, Ludovic.Desroches@...rochip.com,
        Cristian.Birsan@...rochip.com, linux-usb@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: host: ohci-at91: suspend/resume ports after/before
 OHCI accesses

On Wed, Jun 23, 2021 at 02:33:14PM +0000, Claudiu.Beznea@...rochip.com wrote:
> On 23.06.2021 17:19, Alan Stern wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On Wed, Jun 23, 2021 at 02:09:16PM +0000, Claudiu.Beznea@...rochip.com wrote:
> >> On 23.06.2021 16:59, Alan Stern wrote:
> >>> One thing you might consider changing: The name of the
> >>> ohci_at91_port_suspend routine is misleading.  It doesn't really
> >>> handle suspending the port; instead it handles the clocks that drive
> >>> the entire OHCI controller.  Right?
> >>
> >> It does both as far as I can tell at the moment.
> > 
> > But the name suggests that it only handles suspending a port.  That's
> > misleading.
> > 
> > And the way it is used in the SetPortFeature(USB_PORT_FEAT_SUSPEND)
> > case in ohci_at91_hub_control is just plain wrong.  It won't merely
> > suspend a single port; it will disable the entire OHCI controller.
> 
> Agree with all the above!

Are there any systems beside the SAMA7G5 and others you tested which 
might be affected by this patch?  Do they all work pretty much the 
same way?  (I want to make sure no others will be adversely affected 
by this change.)

Alan Stern