linux-kernel - Re: [PATCH v38 1/4] scsi: ufs: Introduce HPB feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a71d4c3-2f1f-3c85-eb90-381775e7030e@acm.org>
Date:   Wed, 23 Jun 2021 11:13:19 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     daejun7.park@...sung.com, Greg KH <gregkh@...uxfoundation.org>,
        "avri.altman@....com" <avri.altman@....com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "huobean@...il.com" <huobean@...il.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>
Cc:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        JinHwan Park <jh.i.park@...sung.com>,
        Javier Gonzalez <javier.gonz@...sung.com>,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        Dukhyun Kwon <d_hyun.kwon@...sung.com>,
        Keoseong Park <keosung.park@...sung.com>,
        Jaemyung Lee <jaemyung.lee@...sung.com>,
        Jieon Seol <jieon.seol@...sung.com>
Subject: Re: [PATCH v38 1/4] scsi: ufs: Introduce HPB feature

On 6/16/21 12:08 AM, Daejun Park wrote:
> +What:		/sys/class/scsi_device/*/device/unit_descriptor/hpb_pinned_region_start_offset
> +Date:		June 2021
> +Contact:	Daejun Park <daejun7.park@...sung.com>
> +Description:	This entry shows the start offset of HPB pinned region.
> +
> +		The file is read only.
> +
> +What:		/June/class/scsi_device/*/device/unit_descriptor/hpb_number_pinned_regions
> +Date:		March 2021

Please change /June into /sys and "March 2021" into "June 2021".

> @@ -7094,6 +7119,7 @@ static int ufshcd_host_reset_and_restore(struct ufs_hba *hba)
>  {
>  	int err;
>  
> +	ufshpb_reset_host(hba);
>  	/*
>  	 * Stop the host controller and complete the requests
>  	 * cleared by h/w

Shouldn't the ufshpb_reset_host() call occur under the comment instead
of above?

Thanks,

Bart.