linux-kernel - Re: [PATCH net 2/2] ptp: idt82p33: implement double dco time correction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210624034343.GB6853@hoboy.vegasvil.org>
Date:   Wed, 23 Jun 2021 20:43:43 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     min.li.xe@...esas.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 2/2] ptp: idt82p33: implement double dco time
 correction

On Wed, Jun 23, 2021 at 10:46:25AM -0400, min.li.xe@...esas.com wrote:
> +static int idt82p33_start_ddco(struct idt82p33_channel *channel, s32 delta_ns)
> +{
> +	s32 current_ppm = channel->current_freq;
> +	u32 duration_ms = MSEC_PER_SEC;

What happens if user space makes a new adjustment before this
completes?

After all, some PTP profiles update the clock several times per
second.

Thanks,
Richard