linux-kernel - Re: [PATCH v2 2/2] clk: qcom: Add MSM8976/56 Global Clock Controller (GCC) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210624193954.GA1862253@robh.at.kernel.org>
Date:   Thu, 24 Jun 2021 13:39:54 -0600
From:   Rob Herring <robh@...nel.org>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, martin.botka@...ainline.org,
        angelogioacchino.delregno@...ainline.org,
        marijn.suijten@...ainline.org, jamipkettunen@...ainline.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Taniya Das <tdas@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] clk: qcom: Add MSM8976/56 Global Clock Controller
 (GCC) driver

On Sat, Jun 12, 2021 at 10:43:16PM +0200, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
> 
> Add support for the global clock controller found on MSM8956
> and MSM8976 SoCs.
> Since the multimedia clocks are actually in the GCC on these
> SoCs, this will allow drivers to probe and control basically
> all the required clocks.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
> Co-developed-by: Marijn Suijten <marijn.suijten@...ainline.org>
> Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org>
> Co-developed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
> ---
> Changes since v1:
> - Remove the bool in probe function
> - Clean up ".name =" clk lookup
> - Add a comment under gpll0_vote clarifying that it's crucial
> - Removed CLK_GET_RATE_NOCACHE from display clocks, it still works \o/
> 
>  drivers/clk/qcom/Kconfig                     |    8 +
>  drivers/clk/qcom/Makefile                    |    1 +
>  drivers/clk/qcom/gcc-msm8976.c               | 4173 ++++++++++++++++++
>  include/dt-bindings/clock/qcom,gcc-msm8976.h |  243 +

This belongs in the binding patch and dual license it please.

>  4 files changed, 4425 insertions(+)
>  create mode 100644 drivers/clk/qcom/gcc-msm8976.c
>  create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8976.h