linux-kernel - Re: [PATCH] i2c: i2c-dev: Add _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YNThj3wA0P7/twn3@kunai>
Date:   Thu, 24 Jun 2021 21:48:31 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Andreas Hecht <andreas.e.hecht@...il.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: i2c-dev: Add __user annotation

On Thu, Jun 24, 2021 at 05:25:35PM +0200, Andreas Hecht wrote:
> Fix Sparse warnings:
> drivers/i2c/i2c-dev.c:546:19: warning: incorrect type in assignment (different address spaces)
> drivers/i2c/i2c-dev.c:549:53: warning: incorrect type in argument 2 (different address spaces)
> 
> compat_ptr() returns a pointer tagged __user which gets assigned to a
> pointer missing the __user annotation. The same pointer is passed to
> copy_from_user() as an argument where it is expected to have the __user
> annotation. Fix both by adding the __user annotation to the pointer.
> 
> Signed-off-by: Andreas Hecht <andreas.e.hecht@...il.com>

Nice catch. Applied to for-current, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)