linux-kernel - Re: linux-next: build failure after merge of the net-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPv3WKdz6n0CZDusDcxDYJFgUNiEj7h=w=iVUAayiwy4Qjz3SQ@mail.gmail.com>
Date:   Thu, 24 Jun 2021 22:18:44 +0200
From:   Marcin Wojtas <mw@...ihalf.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        lkft-triage@...ts.linaro.org, Nathan Chancellor <nathan@...nel.org>
Subject: Re: linux-next: build failure after merge of the net-next tree

Hi Jakub,

Thanks for your prompt response.

czw., 24 cze 2021 o 21:14 Jakub Kicinski <kuba@...nel.org> napisał(a):
>
> On Thu, 24 Jun 2021 20:15:00 +0200 Marcin Wojtas wrote:
> > TL;DR, we need to get rid of a helper routine (introduced so that to
> > address review comments of v1), as it causes a depmod cycles when
> > fwnode_/of_/acpi_mdio are built as modules.
> > It can be done twofold:
> > a. 3 commits, i.e:
> >   Revert "net: mdiobus: Introduce fwnode_mdbiobus_register()"
> >   Revert "net/fsl: switch to fwnode_mdiobus_register"
> >   net: mvmdio: resign from fwnode_mdiobus_register
> > b. Same diff but squashed.
> >
> > Please let me know your preference, so that I can do it properly up front.
>
> Not sure if Dave will notice this mid-thread question. It probably
> doesn't matter as long as (1) doesn't introduce further transient
> build failures.

I think I'll go with the squashed rollback commit that removes the
problematic helper, as it may be easier to apply. I'll double check
modules_install before.

Best regards,
Marcin