linux-kernel - Re: [PATCH v1] dt-bindings: mmc: change compatiable string for MT8195 mmc host IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210624204655.GA1960751@robh.at.kernel.org>
Date:   Thu, 24 Jun 2021 14:46:55 -0600
From:   Rob Herring <robh@...nel.org>
To:     Wenbin Mei <wenbin.mei@...iatek.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Seiya Wang <seiya.wang@...iatek.com>,
        devicetree@...r.kernel.org, linux-mmc@...r.kernel.org,
        srv_heupstream@...iatek.com, linux-kernel@...r.kernel.org,
        Chaotian Jing <chaotian.jing@...iatek.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mediatek@...ts.infradead.org,
        Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH v1] dt-bindings: mmc: change compatiable string for
 MT8195 mmc host IP

On Tue, 15 Jun 2021 11:00:33 +0800, Wenbin Mei wrote:
> MT8195 mmc host IP is compatible with MT8183, and currently it shows:
> properties:
>   compatible:
>     oneOf:
> ...
>       - items:
>          - const: mediatek,mt8192-mmc
>          - const: mediatek,mt8195-mmc
>          - const: mediatek,mt8183-mmc
> which means the compatible string in the device tree would be:
> 	compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc",
> 		     "mediatek,mt8183-mmc";
> The bindings is wrong and that isn't the result we want.
> instead we want:
> properties:
>   compatible:
>     oneOf:
> ...
>       - items:
>          - const: mediatek,mt8192-mmc
>          - const: mediatek,mt8183-mmc
>       - items:
>          - const: mediatek,mt8195-mmc
>          - const: mediatek,mt8183-mmc
> which would give us:
> 	compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc";
> and
> 	compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc";
> 
> Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195)
> Signed-off-by: Wenbin Mei <wenbin.mei@...iatek.com>
> ---
>  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring <robh@...nel.org>