linux-kernel - Re: [PATCH v3] block: fix trace completion for chained bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YNQt7XtxrFhLhS7E@infradead.org>
Date:   Thu, 24 Jun 2021 08:02:05 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Edward Hsieh <edwardh@...ology.com>
Cc:     Christoph Hellwig <hch@...radead.org>, axboe@...nel.dk,
        neilb@...e.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, s3t@...ology.com,
        bingjingc@...ology.com, cccheng@...ology.com,
        Wade Liang <wadel@...ology.com>
Subject: Re: [PATCH v3] block: fix trace completion for chained bio

On Thu, Jun 24, 2021 at 02:50:30PM +0800, Edward Hsieh wrote:
> We are suggested by Neil Brown in the last version that from the
> comment, the bio_chain_endio handling is used *only* to avoid
> deep recursion so it should be at the end of the function.
> Therefore, the position of blk_throtl_bio_endio() and bio_uninit()
> are a bit odd.

This is BS.  Placement of an else after a returning statement does
not change code generation.

> If it's not necessary then V2 patch should work to fix the
> missing completion traces. Should we resend PATCH V2?

Please send an updated version.