linux-kernel - Re: [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full path of file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Jun 2021 10:46:56 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Justin He <Justin.He@....com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Jonathan Corbet <corbet@....net>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Eric Biggers <ebiggers@...gle.com>,
        "Ahmed S. Darwish" <a.darwish@...utronix.de>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Christoph Hellwig <hch@...radead.org>, nd <nd@....com>
Subject: Re: [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full path of
 file

On Wed 2021-06-23 03:14:33, Justin He wrote:
> Hi Andy
> 
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Sent: Tuesday, June 22, 2021 10:40 PM
> > To: Justin He <Justin.He@....com>
> > Cc: Petr Mladek <pmladek@...e.com>; Steven Rostedt <rostedt@...dmis.org>;
> > Sergey Senozhatsky <senozhatsky@...omium.org>; Rasmus Villemoes
> > <linux@...musvillemoes.dk>; Jonathan Corbet <corbet@....net>; Alexander
> > Viro <viro@...iv.linux.org.uk>; Linus Torvalds <torvalds@...ux-
> > foundation.org>; Peter Zijlstra (Intel) <peterz@...radead.org>; Eric
> > Biggers <ebiggers@...gle.com>; Ahmed S. Darwish <a.darwish@...utronix.de>;
> > linux-doc@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> > fsdevel@...r.kernel.org; Matthew Wilcox <willy@...radead.org>; Christoph
> > Hellwig <hch@...radead.org>; nd <nd@....com>
> > Subject: Re: [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full path
> > of file
> > 
> > On Tue, Jun 22, 2021 at 10:06:32PM +0800, Jia He wrote:
> > > Previously, the specifier '%pD' is for printing dentry name of struct
> > > file. It may not be perfect (by default it only prints one component.)
> > >
> > > As suggested by Linus [1]:
> > 
> > Citing is better looked when you shift right it by two white spaces.
> 
> Okay, I plan to cite it with "> "

My understanding is that Andy suggested to omit '>' and prefix it by
plain two spaces "  ". It would look better to me as well.

Best Regards,
Petr