linux-kernel - Re: [PATCH] ARM: pxa: ssp: remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210624092426.GQ22278@shell.armlinux.org.uk>
Date:   Thu, 24 Jun 2021 10:24:26 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     13145886936@....com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        gushengxian <gushengxian@...ong.com>
Subject: Re: [PATCH] ARM: pxa: ssp: remove unnecessary print function
 dev_err()

On Wed, Jun 23, 2021 at 07:41:39PM -0700, 13145886936@....com wrote:
> From: gushengxian <gushengxian@...ong.com>
> 
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
> 
> Signed-off-by: gushengxian <gushengxian@...ong.com>
> ---
>  arch/arm/plat-pxa/ssp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
> index 563440315acd..96b8765e4f57 100644
> --- a/arch/arm/plat-pxa/ssp.c
> +++ b/arch/arm/plat-pxa/ssp.c
> @@ -147,7 +147,6 @@ static int pxa_ssp_probe(struct platform_device *pdev)
>  
>  	ssp->irq = platform_get_irq(pdev, 0);
>  	if (ssp->irq < 0) {
> -		dev_err(dev, "no IRQ resource defined\n");
>  		return -ENODEV;
>  	}

Please also remove the now unnecessary braces around the return block.
Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!