linux-kernel - Re: [PATCH] Documentation, dt, numa: Add note to empty NUMA node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6cdc518-3bd7-2b66-acd0-c4d53d360eae@infradead.org>
Date:   Wed, 23 Jun 2021 19:14:21 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Gavin Shan <gshan@...hat.com>, devicetree@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        drjones@...hat.com, shan.gavin@...il.com
Subject: Re: [PATCH] Documentation, dt, numa: Add note to empty NUMA node

On 6/23/21 8:37 PM, Gavin Shan wrote:
> The empty NUMA nodes, where no memory resides in, are allowed. For
> these empty NUMA nodes, the 'len' of 'reg' property is zero. These
> empty NUMA node IDs are still valid and parsed. I finds difficulty
> to get where it's properly documented.
> 
> So lets add note to empty NUMA nodes in the NUMA binding doc.
> 
> Signed-off-by: Gavin Shan <gshan@...hat.com>
> ---
>  Documentation/devicetree/bindings/numa.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt
> index 21b35053ca5a..c564705c0eac 100644
> --- a/Documentation/devicetree/bindings/numa.txt
> +++ b/Documentation/devicetree/bindings/numa.txt
> @@ -109,6 +109,10 @@ Example:
>  Dual socket system consists of 2 boards connected through ccn bus and
>  each board having one socket/soc of 8 cpus, memory and pci bus.
>  
> +Note that the empty NUMA nodes, which no memory resides in, are allowed

Missing period at end of the sentence above.

> +Their NUMA node IDs are still valid so that memory can be added into these
> +NUMA nodes through hotplug afterwards.
> +
>  	memory@...000 {
>  		device_type = "memory";
>  		reg = <0x0 0xc00000 0x0 0x80000000>;


thanks.