linux-kernel - Re: [PATCH v4] HID: input: Add support for Programmable Buttons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 Jun 2021 15:41:30 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Thomas Weißschuh <linux@...ssschuh.net>
cc:     linux-input@...r.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] HID: input: Add support for Programmable Buttons

On Tue, 15 Jun 2021, Thomas Weißschuh wrote:

> Map them to KEY_MACRO# event codes.
> 
> These buttons are defined by HID as follows:
> "The user defines the function of these buttons to control software applications or GUI objects."
> 
> This matches the semantics of the KEY_MACRO# input event codes that Linux supports.
> 
> Also add support for HID "Named Array" collections.
> Also add hid-debug support for KEY_MACRO#.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
> 
> ---
> 
> v1: https://lore.kernel.org/linux-input/20210519160349.609690-1-linux@weissschuh.net/
> 
> v1 -> v2: Only handle the 30 keys known
> 
> v2: https://lore.kernel.org/linux-input/20210519174345.614467-1-linux@weissschuh.net/
> 
> v2 -> v3:
>  * Use hex constants for consistency
>  * Validate that the button is part of a "Programmable Buttons" Named Array.
>    Otherwise the condition would also apply to "Function Buttons".
>  * Ignore non-"Programmable Buttons" buttons.
> 
> v3: https://lore.kernel.org/linux-input/20210520084805.685486-1-linux@weissschuh.net/
> 
> v3 -> v4:
>  * Mention new support for HID "Named Array" collections in commit message.
>  * Mention new support KEY_MACRO# in hid-debug.

Applied, thank you.

-- 
Jiri Kosina
SUSE Labs