linux-kernel - Re: [PATCH v2 1/1] dmaengine: dw: Program xBAR hardware for Elkhart Lake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YNSNNmd/OYxUDGhW@smile.fi.intel.com>
Date:   Thu, 24 Jun 2021 16:48:38 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        Viresh Kumar <vireshk@...nel.org>
Subject: Re: [PATCH v2 1/1] dmaengine: dw: Program xBAR hardware for Elkhart
 Lake

On Thu, Jun 24, 2021 at 04:46:32PM +0530, Vinod Koul wrote:
> On 14-06-21, 16:30, Andy Shevchenko wrote:
> > Intel Elkhart Lake PSE DMA implementation is integrated with crossbar IP
> > in order to serve more hardware than there are DMA request lines available.
> > 
> > Due to this, program xBAR hardware to make flexible support of PSE peripheral.
> > 
> > The Device-to-Device has not been tested and it's not supported by DMA Engine,
> > but it's left in the code for the sake of documenting hardware features.
> 
> Kernel does not like to keep dead code, please remove this. It can be
> added back when we have users

I would rather keep it as documentation (converted to comment perhaps).
In any case, it seems the suitable point of time to contribute will be
already after v5.14-rc1.

-- 
With Best Regards,
Andy Shevchenko