linux-kernel - Re: [PATCH] pinctrl: bcm2835: Replace BUG with BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7dd8b65e-0f89-9aa9-9eab-6cbc6c9495bb@gmail.com>
Date:   Thu, 24 Jun 2021 09:22:38 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jason Wang <wangborong@...rlc.com>, linus.walleij@...aro.org
Cc:     nsaenz@...nel.org, rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, phil@...pberrypi.com,
        iivanov@...e.de, linux-gpio@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: bcm2835: Replace BUG with BUG_ON

On 6/23/21 11:49 PM, Jason Wang wrote:
> The if condition followed by BUG can be replaced to BUG_ON which is
> more compact and formal in linux source.
> 
> Signed-off-by: Jason Wang <wangborong@...rlc.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Although I would rather completely remove this BUG_ON() and replace it
with a WARN_ON() instead, no need to kill the machine for such a
problem, however unlikely it is to appear.
-- 
Florian