linux-kernel - Re: [GIT PULL] MMC fixes for v5.13-rc8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Jun 2021 11:00:11 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-mmc@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] MMC fixes for v5.13-rc8

On Thu, Jun 24, 2021 at 5:32 AM Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> Neil Armstrong (1):
>       mmc: meson-gx: use memcpy_to/fromio for dram-access-quirk

Ugh. How horribly ugly.

Why is that 'host->dram_access_quirk' test _inside_ the loop, rather
than be something like

        if (host->dram_access_quirk)
                return sg_copy_to_buffer(data->sg, data->sg_len,
                                host->bounce_buf, xfer_bytes);

at the top of the function, with meson_mmc_copy_buffer() then only
handling the mmio case?

No, I don't know this code, I'm just looking at the patch and going
"that looks really ugly".

Anyway, I've pulled it, but I thought I'd voice my reaction to it..

              Linus