linux-kernel - Re: [PATCH] kunit: tool: remove unnecessary "annotations" import

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABVgOSm3m2NMZqHSpDRexs_EOdC7SnKmb_iTb738iZPW0m_Nrg@mail.gmail.com>
Date:   Fri, 25 Jun 2021 12:17:23 +0800
From:   David Gow <davidgow@...gle.com>
To:     Daniel Latypov <dlatypov@...gle.com>
Cc:     Brendan Higgins <brendanhiggins@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        KUnit Development <kunit-dev@...glegroups.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kunit: tool: remove unnecessary "annotations" import

On Thu, Jun 24, 2021 at 3:09 AM Daniel Latypov <dlatypov@...gle.com> wrote:
>
> The import was working around the fact "tuple[T]" was used instead of
> typing.Tuple[T].
>
> Convert it to use type.Tuple to be consistent with how the rest of the
> code is anotated.
>
> Signed-off-by: Daniel Latypov <dlatypov@...gle.com>
> ---

This looks sensible and works for me.

Reviewed-by: David Gow <davidgow@...gle.com>

Thanks,
-- David

>  tools/testing/kunit/kunit_kernel.py | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/kunit/kunit_kernel.py b/tools/testing/kunit/kunit_kernel.py
> index e1951fa60027..5987d5b1b874 100644
> --- a/tools/testing/kunit/kunit_kernel.py
> +++ b/tools/testing/kunit/kunit_kernel.py
> @@ -6,15 +6,13 @@
>  # Author: Felix Guo <felixguoxiuping@...il.com>
>  # Author: Brendan Higgins <brendanhiggins@...gle.com>
>
> -from __future__ import annotations
>  import importlib.util
>  import logging
>  import subprocess
>  import os
>  import shutil
>  import signal
> -from typing import Iterator
> -from typing import Optional
> +from typing import Iterator, Optional, Tuple
>
>  from contextlib import ExitStack
>
> @@ -208,7 +206,7 @@ def get_source_tree_ops(arch: str, cross_compile: Optional[str]) -> LinuxSourceT
>                 raise ConfigError(arch + ' is not a valid arch')
>
>  def get_source_tree_ops_from_qemu_config(config_path: str,
> -                                        cross_compile: Optional[str]) -> tuple[
> +                                        cross_compile: Optional[str]) -> Tuple[
>                                                          str, LinuxSourceTreeOperations]:
>         # The module name/path has very little to do with where the actual file
>         # exists (I learned this through experimentation and could not find it
>
> base-commit: 87c9c16317882dd6dbbc07e349bc3223e14f3244
> --
> 2.32.0.93.g670b81a890-goog
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4000 bytes)