linux-kernel - Re: [PATCH 1/1] RDMA/cma: Fix rdma_resolve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27a35a75-813d-ef1e-c9ca-d4ecbc5a95d2@nvidia.com>
Date:   Fri, 25 Jun 2021 13:49:11 +0800
From:   Mark Zhang <markzhang@...dia.com>
To:     Gerd Rausch <gerd.rausch@...cle.com>, <linux-rdma@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH 1/1] RDMA/cma: Fix rdma_resolve_route memory leak

On 6/25/2021 2:55 AM, Gerd Rausch wrote:
> Fix a memory leak when "rmda_resolve_route" is called
> more than once on the same "rdma_cm_id".
> 
> Signed-off-by: Gerd Rausch <gerd.rausch@...cle.com>
> ---
>   drivers/infiniband/core/cma.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> index ab148a696c0c..4a76d5b4163e 100644
> --- a/drivers/infiniband/core/cma.c
> +++ b/drivers/infiniband/core/cma.c
> @@ -2819,7 +2819,8 @@ static int cma_resolve_ib_route(struct rdma_id_private *id_priv,
>   
>   	cma_init_resolve_route_work(work, id_priv);
>   
> -	route->path_rec = kmalloc(sizeof *route->path_rec, GFP_KERNEL);
> +	if (!route->path_rec)
> +		route->path_rec = kmalloc(sizeof *route->path_rec, GFP_KERNEL);
>   	if (!route->path_rec) {
>   		ret = -ENOMEM;
>   		goto err1;

If route->path_rec does exist (meaning this is not the first time 
called), then it would be freed if cma_query_ib_route() below is failed, 
is it good?