linux-kernel - Re: [PATCH v2] gpio: mxs: Prefer unsigned int to bare use of unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 25 Jun 2021 12:34:14 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Jinchao Wang <wjc@...rlc.com>
Cc:     "andy.shevchenko" <andy.shevchenko@...il.com>,
        shawnguo <shawnguo@...nel.org>,
        "s.hauer" <s.hauer@...gutronix.de>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] gpio: mxs: Prefer unsigned int to bare use of unsigned

On Thu, Jun 24, 2021 at 12:15 PM Jinchao Wang <wjc@...rlc.com> wrote:
>
> Fix checkpatch warnings:
>     WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Jinchao Wang <wjc@...rlc.com>
> ---
> - changes for v2:
> - Use full prefix
>
> ---
>  drivers/gpio/gpio-mxs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
> index 524b668eb1ac..31a336b86ff2 100644
> --- a/drivers/gpio/gpio-mxs.c
> +++ b/drivers/gpio/gpio-mxs.c
> @@ -229,14 +229,14 @@ static int mxs_gpio_init_gc(struct mxs_gpio_port *port, int irq_base)
>         return rv;
>  }
>
> -static int mxs_gpio_to_irq(struct gpio_chip *gc, unsigned offset)
> +static int mxs_gpio_to_irq(struct gpio_chip *gc, unsigned int offset)
>  {
>         struct mxs_gpio_port *port = gpiochip_get_data(gc);
>
>         return irq_find_mapping(port->domain, offset);
>  }
>
> -static int mxs_gpio_get_direction(struct gpio_chip *gc, unsigned offset)
> +static int mxs_gpio_get_direction(struct gpio_chip *gc, unsigned int offset)
>  {
>         struct mxs_gpio_port *port = gpiochip_get_data(gc);
>         u32 mask = 1 << offset;
> --
> 2.31.1
>

Applied, thanks!

Bartosz