lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Jun 2021 02:06:13 +0100 From: Matthew Wilcox <willy@...radead.org> To: Christoph Hellwig <hch@...radead.org> Cc: akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 41/46] mm/page_alloc: Add folio allocation functions On Wed, Jun 23, 2021 at 11:58:02AM +0200, Christoph Hellwig wrote: > On Tue, Jun 22, 2021 at 01:15:46PM +0100, Matthew Wilcox (Oracle) wrote: > > +static inline > > +struct folio *__alloc_folio_node(gfp_t gfp, unsigned int order, int nid) > > Weirdo prototype formatting. > > Otherwise looks good (assuming we grow callers): The next patch adds filemap_alloc_folio() which uses these. That then gets used in "mm/filemap: Add filemap_get_folio", which is the patch after that. Now that I look at this patch again, I wonder if this shouldn't be folio_alloc(), __folio_alloc() and __folio_alloc_node. And even though I have no users yet, completing the set with folio_alloc_node() might be a good idea. > Reviewed-by: Christoph Hellwig <hch@....de>
Powered by blists - more mailing lists