linux-kernel - Re: [PATCH v2] Documentation, dt, numa: Add note to empty NUMA node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <834b6b3a-c56b-b8e3-f401-30fdc689d6a2@infradead.org>
Date:   Thu, 24 Jun 2021 18:49:08 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Gavin Shan <gshan@...hat.com>, devicetree@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        drjones@...hat.com, shan.gavin@...il.com
Subject: Re: [PATCH v2] Documentation, dt, numa: Add note to empty NUMA node

On 6/24/21 7:03 PM, Gavin Shan wrote:
> The empty NUMA nodes, where no memory resides in, are allowed. For
> these empty NUMA nodes, the 'len' of 'reg' property is zero. These
> empty NUMA node IDs are still valid and parsed. I finds difficulty
> to get where it's properly documented.
> 
> So lets add note to empty NUMA nodes in the NUMA binding doc.
> 
> Signed-off-by: Gavin Shan <gshan@...hat.com>
> ---
> v2: Update to address Randy's comments

Hi Gavin,

Sorry, there has been some misunderstanding. Please see below.


> ---
>  Documentation/devicetree/bindings/numa.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt
> index 21b35053ca5a..08e361f9954c 100644
> --- a/Documentation/devicetree/bindings/numa.txt
> +++ b/Documentation/devicetree/bindings/numa.txt
> @@ -109,6 +109,10 @@ Example:
>  Dual socket system consists of 2 boards connected through ccn bus and
>  each board having one socket/soc of 8 cpus, memory and pci bus.
>  
> +Note that the empty NUMA nodes, which no memory resides in period, are

In patch v1, this was:

  +Note that the empty NUMA nodes, which no memory resides in, are allowed 

and I said:

  Missing period at end of the sentence above.

What I meant by that was "Missing 'period' ('.') punctuation at the end
of the sentence above. So it should simply be changed to:


  +Note that the empty NUMA nodes, which no memory resides in, are allowed.



> +allowed. Their NUMA node IDs are still valid so that memory can be added
> +into these NUMA nodes through hotplug afterwards.
> +
>  	memory@...000 {
>  		device_type = "memory";
>  		reg = <0x0 0xc00000 0x0 0x80000000>;

Sorry about the confusion.