linux-kernel - RE: [PATCH 2/6] firmware: xilinx: add macros of node ids for error event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BY5PR02MB6817E2EA9C7F5059CEE69D67A1069@BY5PR02MB6817.namprd02.prod.outlook.com>
Date:   Fri, 25 Jun 2021 13:35:43 +0000
From:   Abhyuday Godhasara <agodhasa@...inx.com>
To:     Michal Simek <michals@...inx.com>
CC:     Rajan Vaja <RAJANV@...inx.com>, Manish Narani <MNARANI@...inx.com>,
        "zou_wei@...wei.com" <zou_wei@...wei.com>,
        Amit Sunil Dhamne <amitsuni@...x.xilinx.com>,
        Sai Krishna Potthuri <lakshmis@...inx.com>,
        Jiaying Liang <jliang@...inx.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH 2/6] firmware: xilinx: add macros of node ids for error
 event

Hi,

> -----Original Message-----
> From: Michal Simek <michal.simek@...inx.com>
> Sent: Monday, June 21, 2021 4:42 PM
> To: Abhyuday Godhasara <agodhasa@...inx.com>; Michal Simek
> <michals@...inx.com>
> Cc: Rajan Vaja <RAJANV@...inx.com>; Manish Narani <MNARANI@...inx.com>;
> zou_wei@...wei.com; Amit Sunil Dhamne <amitsuni@...x.xilinx.com>; Sai
> Krishna Potthuri <lakshmis@...inx.com>; Jiaying Liang <jliang@...inx.com>;
> linux-kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH 2/6] firmware: xilinx: add macros of node ids for error
> event
> 
> 
> 
> On 5/28/21 5:59 PM, Abhyuday Godhasara wrote:
> > Add macros for the Node-Id of Error events.
> >
> > Move supported api callback ids from zynqmp-power to zynqmp-firmware.
> >
> > Signed-off-by: Rajan Vaja <rajan.vaja@...inx.com>
> > Signed-off-by: Abhyuday Godhasara <abhyuday.godhasara@...inx.com>
> > ---
> >  drivers/soc/xilinx/zynqmp_power.c    |  6 ------
> >  include/linux/firmware/xlnx-zynqmp.h | 13 +++++++++++++
> >  2 files changed, 13 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/soc/xilinx/zynqmp_power.c
> > b/drivers/soc/xilinx/zynqmp_power.c
> > index c556623..76478fe 100644
> > --- a/drivers/soc/xilinx/zynqmp_power.c
> > +++ b/drivers/soc/xilinx/zynqmp_power.c
> > @@ -46,12 +46,6 @@ static const char *const suspend_modes[] = {
> >
> >  static enum pm_suspend_mode suspend_mode = PM_SUSPEND_MODE_STD;
> >
> > -enum pm_api_cb_id {
> > -	PM_INIT_SUSPEND_CB = 30,
> > -	PM_ACKNOWLEDGE_CB,
> > -	PM_NOTIFY_CB,
> > -};
> > -
> >  static void zynqmp_pm_get_callback_data(u32 *buf)  {
> >  	zynqmp_pm_invoke_fn(GET_CALLBACK_DATA, 0, 0, 0, 0, buf); diff --git
> > a/include/linux/firmware/xlnx-zynqmp.h
> > b/include/linux/firmware/xlnx-zynqmp.h
> > index 6557832..c715756 100644
> > --- a/include/linux/firmware/xlnx-zynqmp.h
> > +++ b/include/linux/firmware/xlnx-zynqmp.h
> > @@ -60,6 +60,19 @@
> >  #define XILINX_ZYNQMP_PM_FPGA_FULL	0x0U
> >  #define XILINX_ZYNQMP_PM_FPGA_PARTIAL	BIT(0)
> >
> > +/*
> > + * Node IDs for the Error Events.
> > + */
> > +#define EVENT_ERROR_PMC_ERR1	(0x28100000U)
> > +#define EVENT_ERROR_PMC_ERR2	(0x28104000U)
> > +#define EVENT_ERROR_PSM_ERR1	(0x28108000U)
> > +#define EVENT_ERROR_PSM_ERR2	(0x2810C000U)
> > +
> > +enum pm_api_cb_id {
> > +	PM_INIT_SUSPEND_CB = 30,
> 
> No information about why PM_ACKNOWLEDGE_CB was removed. Doing it via
> separate patch would be the best.
[Abhyuday] Will not remove PM_ACKNOWLEDGE_CB as to be in sync with firmware.

> 
> M
> 
> > +	PM_NOTIFY_CB = 32,
> > +};
> > +
> >  enum pm_api_id {
> >  	PM_GET_API_VERSION = 1,
> >  	PM_REGISTER_NOTIFIER = 5,
> >

Thanks,
Abhyuday