linux-kernel - Re: [PATCH] nfsd: remove redundant assignment to pointer 'this'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210625145443.GA26192@fieldses.org>
Date:   Fri, 25 Jun 2021 10:54:43 -0400
From:   "J . Bruce Fields" <bfields@...ldses.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Chuck Lever <chuck.lever@...cle.com>, linux-nfs@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfsd: remove redundant assignment to pointer 'this'

Sorry, overlooked this before somehow; applied for 5.14.--b.

On Thu, May 13, 2021 at 04:16:39PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The pointer 'this' is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  fs/nfsd/nfs4proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index f4ce93d7f26e..712df4b7dcb2 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -3232,7 +3232,7 @@ bool nfsd4_spo_must_allow(struct svc_rqst *rqstp)
>  {
>  	struct nfsd4_compoundres *resp = rqstp->rq_resp;
>  	struct nfsd4_compoundargs *argp = rqstp->rq_argp;
> -	struct nfsd4_op *this = &argp->ops[resp->opcnt - 1];
> +	struct nfsd4_op *this;
>  	struct nfsd4_compound_state *cstate = &resp->cstate;
>  	struct nfs4_op_map *allow = &cstate->clp->cl_spo_must_allow;
>  	u32 opiter;
> -- 
> 2.30.2