linux-kernel - Re: [PATCH] HID: i2c-hid: goodix: Tie the reset line to true state of the regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Jun 2021 08:20:51 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     kbuild@...ts.01.org, Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        kbuild test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: i2c-hid: goodix: Tie the reset line to true state of
 the regulator

Hi,

On Tue, Jun 22, 2021 at 1:49 AM Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> 2b87ff72c696bc Douglas Anderson 2021-06-11  133         mutex_lock(&ihid_goodix->regulator_mutex);
>                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 2b87ff72c696bc Douglas Anderson 2021-06-11  134         ihid_goodix->nb.notifier_call = ihid_goodix_vdd_notify;
> 2b87ff72c696bc Douglas Anderson 2021-06-11  135         ret = regulator_register_notifier(ihid_goodix->vdd, &ihid_goodix->nb);
> 2b87ff72c696bc Douglas Anderson 2021-06-11  136         if (ret)
> 2b87ff72c696bc Douglas Anderson 2021-06-11  137                 return dev_err_probe(&client->dev, ret,
> 2b87ff72c696bc Douglas Anderson 2021-06-11  138                         "regulator notifier request failed\n");
>                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Drop the lock before returning?

Thank you for catching that. Fixed in v2:

https://lore.kernel.org/r/20210625081818.v2.1.I358cae5e33f742765fd38485d6ddf1a4a978644d@changeid/

-Doug