[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <305e3cdc-3ffe-91d3-1034-4b7395e301d9@linuxfoundation.org>
Date: Fri, 25 Jun 2021 09:48:46 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>,
Brendan Higgins <brendanhiggins@...gle.com>
Cc: David Gow <davidgow@...gle.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux Next Mailing List <linux-next@...r.kernel.org>,
Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: linux-next: build failure after merge of the kunit-fixes tree
On 6/25/21 4:05 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the kunit-fixes tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> In file included from drivers/thunderbolt/test.c:9:
> drivers/thunderbolt/test.c: In function 'tb_test_path_single_hop_walk':
> drivers/thunderbolt/test.c:455:25: error: 'typeof' applied to a bit-field
> 455 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:455:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 455 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:466:25: error: 'typeof' applied to a bit-field
> 466 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:466:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 466 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c: In function 'tb_test_path_daisy_chain_walk':
> drivers/thunderbolt/test.c:512:25: error: 'typeof' applied to a bit-field
> 512 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:512:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 512 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:523:25: error: 'typeof' applied to a bit-field
> 523 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:523:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 523 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c: In function 'tb_test_path_simple_tree_walk':
> drivers/thunderbolt/test.c:573:25: error: 'typeof' applied to a bit-field
> 573 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:573:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 573 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:584:25: error: 'typeof' applied to a bit-field
> 584 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:584:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 584 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c: In function 'tb_test_path_complex_tree_walk':
> drivers/thunderbolt/test.c:655:25: error: 'typeof' applied to a bit-field
> 655 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:655:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 655 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:666:25: error: 'typeof' applied to a bit-field
> 666 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:666:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 666 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c: In function 'tb_test_path_max_length_walk':
> drivers/thunderbolt/test.c:756:25: error: 'typeof' applied to a bit-field
> 756 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:756:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 756 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:767:25: error: 'typeof' applied to a bit-field
> 767 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:767:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 767 | KUNIT_EXPECT_EQ(test, p->config.type, test_data[i].type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c: In function 'tb_test_path_not_bonded_lane0':
> drivers/thunderbolt/test.c:850:25: error: 'typeof' applied to a bit-field
> 850 | KUNIT_EXPECT_EQ(test, in_port->config.type, test_data[i].in_type);
> | ^~~~~~~
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:850:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 850 | KUNIT_EXPECT_EQ(test, in_port->config.type, test_data[i].in_type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:853:25: error: 'typeof' applied to a bit-field
> 853 | KUNIT_EXPECT_EQ(test, out_port->config.type, test_data[i].out_type);
> | ^~~~~~~~
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:853:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 853 | KUNIT_EXPECT_EQ(test, out_port->config.type, test_data[i].out_type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c: In function 'tb_test_path_not_bonded_lane1':
> drivers/thunderbolt/test.c:910:25: error: 'typeof' applied to a bit-field
> 910 | KUNIT_EXPECT_EQ(test, in_port->config.type, test_data[i].in_type);
> | ^~~~~~~
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:910:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 910 | KUNIT_EXPECT_EQ(test, in_port->config.type, test_data[i].in_type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:913:25: error: 'typeof' applied to a bit-field
> 913 | KUNIT_EXPECT_EQ(test, out_port->config.type, test_data[i].out_type);
> | ^~~~~~~~
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:913:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 913 | KUNIT_EXPECT_EQ(test, out_port->config.type, test_data[i].out_type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c: In function 'tb_test_path_not_bonded_lane1_chain':
> drivers/thunderbolt/test.c:988:25: error: 'typeof' applied to a bit-field
> 988 | KUNIT_EXPECT_EQ(test, in_port->config.type, test_data[i].in_type);
> | ^~~~~~~
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:988:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 988 | KUNIT_EXPECT_EQ(test, in_port->config.type, test_data[i].in_type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:991:25: error: 'typeof' applied to a bit-field
> 991 | KUNIT_EXPECT_EQ(test, out_port->config.type, test_data[i].out_type);
> | ^~~~~~~~
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:991:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 991 | KUNIT_EXPECT_EQ(test, out_port->config.type, test_data[i].out_type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c: In function 'tb_test_path_not_bonded_lane1_chain_reverse':
> drivers/thunderbolt/test.c:1066:25: error: 'typeof' applied to a bit-field
> 1066 | KUNIT_EXPECT_EQ(test, in_port->config.type, test_data[i].in_type);
> | ^~~~~~~
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:1066:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 1066 | KUNIT_EXPECT_EQ(test, in_port->config.type, test_data[i].in_type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:1069:25: error: 'typeof' applied to a bit-field
> 1069 | KUNIT_EXPECT_EQ(test, out_port->config.type, test_data[i].out_type);
> | ^~~~~~~~
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:1069:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 1069 | KUNIT_EXPECT_EQ(test, out_port->config.type, test_data[i].out_type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c: In function 'tb_test_path_mixed_chain':
> drivers/thunderbolt/test.c:1156:25: error: 'typeof' applied to a bit-field
> 1156 | KUNIT_EXPECT_EQ(test, in_port->config.type, test_data[i].in_type);
> | ^~~~~~~
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:1156:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 1156 | KUNIT_EXPECT_EQ(test, in_port->config.type, test_data[i].in_type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:1159:25: error: 'typeof' applied to a bit-field
> 1159 | KUNIT_EXPECT_EQ(test, out_port->config.type, test_data[i].out_type);
> | ^~~~~~~~
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:1159:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 1159 | KUNIT_EXPECT_EQ(test, out_port->config.type, test_data[i].out_type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c: In function 'tb_test_path_mixed_chain_reverse':
> drivers/thunderbolt/test.c:1246:25: error: 'typeof' applied to a bit-field
> 1246 | KUNIT_EXPECT_EQ(test, in_port->config.type, test_data[i].in_type);
> | ^~~~~~~
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:1246:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 1246 | KUNIT_EXPECT_EQ(test, in_port->config.type, test_data[i].in_type);
> | ^~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:1249:25: error: 'typeof' applied to a bit-field
> 1249 | KUNIT_EXPECT_EQ(test, out_port->config.type, test_data[i].out_type);
> | ^~~~~~~~
> include/kunit/test.h:804:9: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 804 | typeof(left) __left = (left); \
> | ^~~~
> include/kunit/test.h:918:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
> 918 | KUNIT_BASE_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:928:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
> 928 | KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1291:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
> 1291 | KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thunderbolt/test.c:1249:3: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 1249 | KUNIT_EXPECT_EQ(test, out_port->config.type, test_data[i].out_type);
> | ^~~~~~~~~~~~~~~
>
> Caused by commit
>
> 8f0877c26e4b ("thunderbolt: test: Remove some casts which are no longer required")
>
I am applying them now. Okay to add your Aked-by Brendan?
thanks,
-- Shuah
Powered by blists - more mailing lists